Remove counter for generating modal ids #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver component and client bundling with next app directory
Collaborator
Say no more, you are right, I was wrong. Let's leave the devs the resposability of enforcing uniqueness of names. Thank you for this other good contribution 👍🏻 |
sbourdon13
pushed a commit
to sbourdon13/react-dsfr
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again :)
This one is more tricky.
During compilation of a next app with server component, sometime the createModal() call happens in 2 different contexts.
The result is a server rendering with
${uncapitalize(name)}-modal-0and a client bundle with${uncapitalize(name)}-modal-1This has caused us a bug during hydration (aria-controls of the hidden modal control button are different), but also the button does not work in production at all since the aria-controls prop have a different id than the modal.
I am ok with the developers having the responsibility of putting unique modal names (as when using basic dsfr js)
But I am aware that this PR is a BC break for this component, what do you think ?